Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extensions): add explicit full 'mini.nvim' support #86

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

echasnovski
Copy link
Contributor

This PR adds full support for 'mini.nvim'. Addresses (part of) #81.

Already present 'mini.files' highlight groups are not changed. Of course, feel free to adjust the rest.

Some notes about highlighting decisions:

  • Explicit links usually indicate that the highlight group is the same as 'mini.nvim' default. If :colorscheme cyberdream is the first and only call in user's config, they are, strictly speaking, not needed. However, they are present to ensure the calling :colorscheme cyberdream after some other color scheme (which might have overridden default highlight) results in the same highlighting.
  • Colors for 'mini.statusline' modes are taken from Heirline highlight groups.
  • Other stylistic choices are made the way I think is best here, which might not be fully in the spirit of the color scheme (again, feel free to manually adjust):
    • Using background highlighting for MiniDiffOverXxx):
    • Vibrant background highlighting in 'mini.hipatterns'.
    • Colorful highlighting of 'mini.jump2d' spots.
    • MiniTablineModifiedXxx being inverted MiniTablineXxx.

small fix to guarantee blend function runs on a solid color (bg can be
"NONE" if transparency is enabled)
@scottmckendry
Copy link
Owner

Incredible! Thanks for working on this @echasnovski!
The only change I've made is to use the solid alternative for the bg color when blending on some of the groups. Probably another good reason to explicitly define these colors instead of dynamically generating them at runtime.

@scottmckendry scottmckendry merged commit 63a4dbe into scottmckendry:main Jun 28, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants