Move SVG renderer logic back into SVGSkin #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adroitwhiz
force-pushed
the
remove-svgrenderer-dependency
branch
from
1a6233b
to
a9d70a5
Compare
adroitwhiz
commented
Feb 5, 2021
adroitwhiz
force-pushed
the
remove-svgrenderer-dependency
branch
from
c9c2e9e
to
40ad5d3
Compare
adroitwhiz
commented
Mar 4, 2021
This will allow for fancier stuff to be done with the SVG viewbox in the future to avoid subpixel jitter.
adroitwhiz
force-pushed
the
remove-svgrenderer-dependency
branch
from
40ad5d3
to
801b0da
Compare
cwillisf
requested changes
Jun 1, 2021
Instead of creating a new image every time `setSVG` is called and checking whether that image is complete with `loaded`, reuse the same image, override its `src`, & use `onload` instead of `addEventListener` to replace the previous event listener. This is necessary to avoid race conditions with the `_svgImageLoaded` flag.
adroitwhiz
force-pushed
the
remove-svgrenderer-dependency
branch
from
e5df8b5
to
7af5b3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on scratchfoundation/scratch-svg-renderer#213
Resolves
A step towards #550
Proposed Changes
This PR moves the logic for actually rendering SVGs back into
SVGSkinfromSvgRenderer, and removes the dependency on theSvgRendererclass.Reason for Changes
This will allow for future modifications to the way SVGs are drawn, which are necessary to fix #550.
Test Coverage
Tested manually