Restore old pen line code #672
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes #671 on both the iPhone and iPad. This does not fix #670 on the iPhone; the result of the repro project is the same, with nothing shown. This almost fixes #670 on the iPad, but there is another issue: diagonal lines with endpoints far offscreen are not drawn correctly: |
|
Hmm, if it's not fixing 670 it doesn't seem worth reverting pen antialiasing |
|
There is no escape from the world of suck that is Apple graphics drivers so let's not make pen lines look worse in the process |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #670
Resolves #671
Proposed Changes
This reverts the pen line drawing code to the one originally written by mzgoddard before I decided to rewrite it.
The pen lines don't look as smooth now but hopefully this should get rid of all the annoying cross-device issues.
Reason for Changes
This should once and for all fix all the annoying device-specific pen bugs.
Test Coverage
I no longer have iOS devices to test on. @RexScratch can you test this on https://adroitwhiz.github.io/scratch-gui/revert-pen/? (It may take a bit for GitHub Pages to stop caching the 404 page)