Remove updateDrawableProperties #722
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #721
Proposed Changes
This PR removes the
updateDrawablePropertiesfunction from the publicRenderWebGLAPI surface, and theDrawable.updatePropertiesfunction. It also adjusts some testing code to no longer use those deprecated APIs.Reason for Changes
As detailed in #721,
updateDrawablePropertieshas been deprecated in favor of individual functions for updating each property separately. As it is no longer called from anywhere in the codebase, it can be removed.Test Coverage
All existing tests (should) pass. I searched through all public LLK repos for
updateDrawablePropertiesandupdateProperties, and the only results are the test code used here, which this PR also fixes.