feat: make verify fn a no-op if not implemented (#74)

screwdriver-cd · Jul 12, 2021 · 048c427 · 048c427
1 parent b53d955
commit 048c427
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/index.js b/index.js
@@ -95,7 +95,7 @@ class Executor {
     }
 
     async _verify() {
-        throw new Error('Not implemented');
+        // no-op in case not implemented in extenders
     }
 
     /**

diff --git a/test/index.test.js b/test/index.test.js
@@ -79,14 +79,13 @@ describe('index test', () => {
             }
         ));
 
-    it('verify returns an error when not overridden', () =>
+    it('verify does not return an error when not overridden', () =>
         instance.verify({}).then(
-            () => {
-                throw new Error('Oh no');
+            message => {
+                assert.equal(message, undefined);
             },
-            err => {
-                assert.isOk(err, 'err is null');
-                assert.equal(err.message, 'Not implemented');
+            () => {
+                throw new Error('should not fail');
             }
         ));