fix: reject with error object instead of string

screwdriver-cd · Sep 27, 2017 · 2fca221 · 2fca221
1 parent 9de6bac
commit 2fca221
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/index.js b/index.js
@@ -50,7 +50,7 @@ class Executor {
     }
 
     _start() {
-        return Promise.reject('Not implemented');
+        return Promise.reject(new Error('Not implemented'));
     }
 
     /**
@@ -66,7 +66,7 @@ class Executor {
     }
 
     _stop() {
-        return Promise.reject('Not implemented');
+        return Promise.reject(new Error('Not implemented'));
     }
 
     /**
@@ -82,7 +82,7 @@ class Executor {
     }
 
     _status() {
-        return Promise.reject('Not implemented');
+        return Promise.reject(new Error('Not implemented'));
     }
 
     /**

diff --git a/test/index.test.js b/test/index.test.js
@@ -58,7 +58,7 @@ describe('index test', () => {
                 throw new Error('Oh no');
             }, (err) => {
                 assert.isOk(err, 'err is null');
-                assert.equal(err, 'Not implemented');
+                assert.equal(err.message, 'Not implemented');
             })
     ));
 
@@ -78,7 +78,7 @@ describe('index test', () => {
                 throw new Error('Oh no');
             }, (err) => {
                 assert.isOk(err, 'error is null');
-                assert.equal(err, 'Not implemented');
+                assert.equal(err.message, 'Not implemented');
             })
     ));
 
@@ -98,7 +98,7 @@ describe('index test', () => {
                 throw new Error('Oh no');
             }, (err) => {
                 assert.isOk(err, 'error is null');
-                assert.equal(err, 'Not implemented');
+                assert.equal(err.message, 'Not implemented');
             })
     ));