Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix for broken stop builds #26

Merged
merged 2 commits into from
May 21, 2020
Merged

fix: fix for broken stop builds #26

merged 2 commits into from
May 21, 2020

Conversation

jithine
Copy link
Member

@jithine jithine commented May 21, 2020

Context

When stop request is issued there is no container information. This cases failures with weighted executor logic.

Objective

Ignore executor selection errors so that default executor can be returned.

References

screwdriver-cd/screwdriver#2083

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Copy link

@parthasl parthasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jithine jithine merged commit 60d05ea into master May 21, 2020
@jithine jithine deleted the new branch May 21, 2020 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants