Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(2288): fix sonarqube setting #31

Merged
merged 1 commit into from
Dec 3, 2020
Merged

fix(2288): fix sonarqube setting #31

merged 1 commit into from
Dec 3, 2020

Conversation

klu909
Copy link
Contributor

@klu909 klu909 commented Dec 1, 2020

Context

Sonarqube setting was broken and doesn't have test execution setting

Objective

Fix sonarqube setting

References

screwdriver-cd/screwdriver#2288

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

jithine
jithine previously approved these changes Dec 3, 2020
Copy link
Member

@jithine jithine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this showing 0% coverage ? https://cd.screwdriver.cd/pipelines/202/builds/665161

@jithine jithine dismissed their stale review December 3, 2020 18:40

need a clarification

@klu909
Copy link
Contributor Author

klu909 commented Dec 3, 2020

why is this showing 0% coverage ? https://cd.screwdriver.cd/pipelines/202/builds/665161

seems like file generate by nyc is empty for this repo

@jithine
Copy link
Member

jithine commented Dec 3, 2020

seems like file generate by nyc is empty for this repo
is that same locally as well ?

@klu909
Copy link
Contributor Author

klu909 commented Dec 3, 2020

seems like file generate by nyc is empty for this repo
is that same locally as well ?

yeah

@klu909 klu909 merged commit 18fff61 into master Dec 3, 2020
@klu909 klu909 deleted the sonar branch December 3, 2020 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants