feat(1572): [1] Add FIXED status to the build #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 16, 2020
wahapo
approved these changes
Aug 18, 2020
|
Can you remove package-lock.json? otherwise LGTM 👍 |
I removed package-lock.json. |
yoshwata
approved these changes
Aug 19, 2020
tkyi
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
feat: screwdriver-cd/screwdriver#1572
Objective
This PR adds the status "FIXED" when a build has failed in the past and the build succeeds again.
Notification-slack-plugin receives a build status label (isFIxed) from screwdriver api.
Therefore, The "FIXED" status uses the same
COLOR_MAPas the "SUCCESS" status.In order for users to receive FIXED notifications, "FAILURE" must be set to screwdriver.yaml.
The image below is a FIXED notification sent by email.
References
issue: screwdriver-cd/screwdriver#1572
[2] notifications-slack screwdriver-cd/notifications-slack#30
[3] screwdriver-api screwdriver-cd/screwdriver#2182
[4] guide screwdriver-cd/guide#407
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.