feat(2719): Scheduled job stop with notification if there's no admin #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkyi
reviewed
Aug 2, 2022
index.js
Outdated
| * @param {String} jobData.message Message | ||
| * @param {Object} jobData.settings Notification setting | ||
| */ | ||
| function jobStatus(jobData) { |
There was a problem hiding this comment.
non-blocking comment: is it possible to refactor buildStatus/jobStatus methods into one method? they seem pretty similar
There was a problem hiding this comment.
thing is that they use different info to send the message, only thing we can abstract is prob the part where we send email, but that was only couple lines. If we are to makes them into same functions there would be a lot of if else branch.
tkyi
approved these changes
Aug 17, 2022
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When scheduled job doesn't run, there's no build nor event for notification plugin to use
Objective
Add ability to notify user with different payload
References
screwdriver-cd/screwdriver#2719
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.