Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(2695): Does not overwrite PR comment that from other PR job #54

Merged
merged 2 commits into from
Jun 10, 2022

Conversation

itleigns
Copy link
Contributor

@itleigns itleigns commented Jun 9, 2022

Context

If multiple jobs have PR comments, the later job's comment overwrites the earlier job's comment.

Objective

We change so that PR comments are only edited by the same job in the same pipeline.

References

https://docs.gitlab.com/ee/api/notes.html
screwdriver-cd/screwdriver#2695
Reflect the following PRs before reflecting this.

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@itleigns
Copy link
Contributor Author

itleigns commented Jun 9, 2022

PR test fails since screwdriver-cd/data-schema#489 is not merged. I will update screwdriver-data-schema version in package.json after the PR is merged.

@itleigns itleigns changed the title [WIP]feat(2695): Does not overwrite PR comment that from other PR job feat(2695): Does not overwrite PR comment that from other PR job Jun 10, 2022
@itleigns
Copy link
Contributor Author

I updated screwdriver-data-schema version and now it works correctly. Please review.

@tkyi tkyi merged commit 7367004 into screwdriver-cd:master Jun 10, 2022
@sd-buildbot
Copy link

🎉 This PR is included in version 2.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@itleigns itleigns deleted the pr-comment branch June 13, 2022 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants