Users cannot notice statuses errors in notification settings.

[ibu1224]

What happened:
Currently, I can not notice the setting mistake of the notification of screwdriver.yaml.

What you expected to happen:
Users need to be aware of any mis-configuration in some way.
How to reproduce it:
Wrong settings, screwdriver.yaml
e.g.

  shared:
    image: node:10
    settings:
      slack:
        channels:
          - ibu1224-test-channel
        statuses:
          - SUCCCESS <---  typo
          - FAILURE

[ibu1224]

I will solve this problem.
I'm thinking of an idea so please wait a moment.

[ibu1224]

Here are idea to solve this problem.
Each notification repository has a validation by joi.
Therefore, add a new function to validate notifications in config-parser.
Each repository has a STATUSES_MAP exists, Use that Key (e.g. SUCCESS) as validation.

@jithine, @kumada626, and contributors.
With agreement, I will start implementing.I would appreciate your feedback.

[tk3fftk]

There is a kind of same issue in annotations.

[wahapo]

It reminds me of my checkAdditionalRules function fix. LGTM.

[jithine]

@ibu1224 your solution sounds good to me.

[jithine]

@ibu1224 is there way to make existing pipelines not break and still have validator throw errors and prevent new pipeline creation ?
So existing pipelines always works and only new pipelines are broken ?

[ibu1224]

@jithine
Hmm ... I think it's difficult.
Notification settings are added at the user's discretion.

Therefore.
We need to validate all pipeline triggers to be able to notice mistakes in the notification settings.

Otherwise, users will not be able to notice that the screwdriver.yaml is wrong.
The pipeline will throw a config-parse-error if the screwdriver.yaml is wrong, whether new or existing.