Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - List view does not scroll #2181

Closed
brian65535 opened this issue Aug 13, 2020 · 2 comments
Closed

UI - List view does not scroll #2181

brian65535 opened this issue Aug 13, 2020 · 2 comments
Labels

Comments

@brian65535
Copy link

brian65535 commented Aug 13, 2020

What happened:
Screwdriver UI list view does not scroll in some browsers. When a pipeline has more jobs than a list view area can show, users should be able to scroll down the list view and the UI show load more jobs into the view area.

But scrolling in list view does not work in some browsers:

  • Chrome 84.0.4147.125
  • Firefox 68.11.0esr

And no scrolling issue in

  • Firefox 79.0

When the issue happens, a workaround to make scrolling work again is to resize down the browser window so that jobs cannot fit in the view area and a scrollbar show up. Once the vertical scrollbar show up, scrolling works fine.

What you expected to happen:
Scrolling should work in the first place in all browsers without resizing the window.

How to reproduce it:

@adong
Copy link
Member

adong commented Aug 13, 2020

This is an issue in ember-light-table version 2.x beta, need to take a deep look

@adong
Copy link
Member

adong commented Aug 13, 2020

I checked out the screwdriver-cd/ui@32d16fa before we upgrade ember-light-table from 1.x to 2.x, and I found the following:

[email protected] was using

    "ember-scrollable": "^0.5.0",
    "ember-in-viewport": "~3.0.3",

while [email protected] was using

    "ember-scrollable": "^1.0.0",
    "ember-in-viewport": "^3.5.8"

It appears to be an issue related to adopted-ember-addons/ember-light-table#693

Ref:

  1. 3.5.0 inViewport injection causes incompatibility with ember-light-table DockYard/ember-in-viewport#186

PS: I do see why it is height="inherit" in

{{#light-table table height="inherit" as |t|}}

because the older version's CSS property is height: inherit.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants