Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests that should be run as helper tests are being run as webhooks plugin tests. #2625

Closed
yk634 opened this issue Dec 23, 2021 · 1 comment
Closed
Milestone

Comments

@yk634
Copy link
Contributor

yk634 commented Dec 23, 2021

What happened:
The issue is caused by the merging of #2622.

In this PR, much of the processing of the webhooks plugin has been consolidated into the helper, which is shared with the processHooks plugin.
With this change, we will have to migrate most of the cases that were tested as webhooks plugin to helper tests.

If the tests is not migrated:

  • Tests running as webhooks plugins make it difficult to know what they are testing (webhooks plugin or helper).
  • When the helper is modified, it will be difficult to find the test target to be modified.

In this PR, we have migrated only some cases that are easy to migrate, but many cases still need to be migrated.

What you expected to happen:
The tests of the webhooks plugin that should be migrated will be migrated to the tests of the helper.

How to reproduce it:
This is not a bug but an issue that need to be refactored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants