Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User cannot know the result when webhook response and backend work are split #2679

Open
yk634 opened this issue Mar 8, 2022 · 1 comment

Comments

@yk634
Copy link
Contributor

yk634 commented Mar 8, 2022

What happened:
The implementation associated with the issue(#1769) allows for a split between backend work and webhook response.

If this feature is used, the user will not know the result of the backend work such as 4XX error or "No jobs to start".
200 is returned as the status code upon successful enqueue of the webhook information.

This is information that can be found in the SCM's hook status if this feature is not used.

What you expected to happen:
Even when splitting the webhook reponse and the backend work, the user can know the result of the backend work

@jithine
Copy link
Member

jithine commented Mar 8, 2022

is that important ? for no jobs to start, we should probably look at alternatives to let users know a webhook activity didn't start an event

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants