From 0e35b3c982984f2af6d03d59427baa8de141142c Mon Sep 17 00:00:00 2001
From: Ming Hay Luk <luk.minghay@gmail.com>
Date: Tue, 3 Sep 2024 14:55:34 -0700
Subject: [PATCH] Remove explicit index route

---
 app/router.js                                   |  4 +---
 app/v2/pipeline/controller.js                   |  2 +-
 app/v2/pipeline/jobs/index/route.js             |  3 ---
 app/v2/pipeline/jobs/index/template.hbs         |  2 --
 tests/unit/v2/pipeline/jobs/index/route-test.js | 12 ------------
 5 files changed, 2 insertions(+), 21 deletions(-)
 delete mode 100644 app/v2/pipeline/jobs/index/route.js
 delete mode 100644 app/v2/pipeline/jobs/index/template.hbs
 delete mode 100644 tests/unit/v2/pipeline/jobs/index/route-test.js

diff --git a/app/router.js b/app/router.js
index d391e215f..61396f7c6 100644
--- a/app/router.js
+++ b/app/router.js
@@ -138,9 +138,7 @@ Router.map(function route() {
         this.route('events', function eventsRoute() {
           this.route('show', { path: '/:event_id' });
         });
-        this.route('jobs', function jobsRoute() {
-          this.route('index', { path: '/' });
-        });
+        this.route('jobs');
         this.route('pulls');
         this.route(
           'build',
diff --git a/app/v2/pipeline/controller.js b/app/v2/pipeline/controller.js
index 9c1807d0d..6b5dd1001 100644
--- a/app/v2/pipeline/controller.js
+++ b/app/v2/pipeline/controller.js
@@ -12,7 +12,7 @@ export default class NewPipelineController extends Controller {
     return [
       'v2.pipeline.events.show',
       'v2.pipeline.pulls',
-      'v2.pipeline.jobs.index'
+      'v2.pipeline.jobs'
     ].includes(currentRouteName);
   }
 }
diff --git a/app/v2/pipeline/jobs/index/route.js b/app/v2/pipeline/jobs/index/route.js
deleted file mode 100644
index 20958f273..000000000
--- a/app/v2/pipeline/jobs/index/route.js
+++ /dev/null
@@ -1,3 +0,0 @@
-import Route from '@ember/routing/route';
-
-export default class NewPipelineJobsIndexRoute extends Route {}
diff --git a/app/v2/pipeline/jobs/index/template.hbs b/app/v2/pipeline/jobs/index/template.hbs
deleted file mode 100644
index cf303da1e..000000000
--- a/app/v2/pipeline/jobs/index/template.hbs
+++ /dev/null
@@ -1,2 +0,0 @@
-{{page-title "Index"}}
-{{outlet}}
\ No newline at end of file
diff --git a/tests/unit/v2/pipeline/jobs/index/route-test.js b/tests/unit/v2/pipeline/jobs/index/route-test.js
deleted file mode 100644
index 30743b655..000000000
--- a/tests/unit/v2/pipeline/jobs/index/route-test.js
+++ /dev/null
@@ -1,12 +0,0 @@
-import { module, test } from 'qunit';
-import { setupTest } from 'screwdriver-ui/tests/helpers';
-
-module('Unit | Route | v2/pipeline/jobs/index', function (hooks) {
-  setupTest(hooks);
-
-  test('it exists', function (assert) {
-    let route = this.owner.lookup('route:v2/pipeline/jobs/index');
-
-    assert.ok(route);
-  });
-});