-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(1082): [13] [small] fix to enable branch specific pr trigger #13
feat(1082): [13] [small] fix to enable branch specific pr trigger #13
Conversation
lib/getNextJobs.js
Outdated
const triggerBranch = config.trigger.match(triggerBranchRegExp); | ||
|
||
if (triggerBranch) { | ||
if (triggerBranch[1].match(edgeSrcBranch[1])) { | ||
if (triggerBranch && triggerBranch[1] === edgeSrcBranch[1]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These looks magic number so I think we should add some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I added some comments.
402dd85
to
716d3cf
Compare
716d3cf
to
4064ed8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Context
The branch specific trigger for
~pr
is not implemented yet.Objective
~pr
jobsReferences