Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up trait bounds #406

Closed
haerdib opened this issue Jan 3, 2023 · 3 comments · Fixed by #541
Closed

Clean up trait bounds #406

haerdib opened this issue Jan 3, 2023 · 3 comments · Fixed by #541
Assignees
Labels
F5-refactor Does not change any functionality of the code Q3-substantial

Comments

@haerdib
Copy link
Contributor

haerdib commented Jan 3, 2023

As @clangenb wrote in #398 (comment) :

I see us repeatedly having these excessive trait bounds. I would vote for adding them to the respective pallet's config, so we don't need to repeat them here every time.

@haerdib haerdib added F5-refactor Does not change any functionality of the code Q3-substantial labels Jan 3, 2023
@haerdib
Copy link
Contributor Author

haerdib commented Jan 4, 2023

@clangenb
Copy link
Collaborator

clangenb commented Jan 5, 2023

I like their approach

@haerdib haerdib self-assigned this Jan 5, 2023
@haerdib haerdib removed their assignment Jan 5, 2023
@haerdib
Copy link
Contributor Author

haerdib commented Jan 10, 2023

Keep in mind: paritytech/substrate#12939. This might prove quite relevant for this issue as well. Defining "by default " parameters is not very dummy proof and will most likely cause issues in the future. With metadata V15, several of these types might be retrievable via metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F5-refactor Does not change any functionality of the code Q3-substantial
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants