-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build and twine check
CI task
#1585
Comments
Currently being added to sfaira: Feel free to just copy the code. |
@ivirshup I've assigned myself and will do it this week. |
That'd be great, thanks! I was thinking it could replace this step in the test builds: And was thinking of using azure for it instead of actions, just to consolidate CI stuff a bit. I was thinking a build and check could just be a separate job? Open to suggestions on this however. |
Yeah, guess eventually we should settle on one CI service. Effectively we should get rid of Travis, since they have serious problems.
Well you have to build the wheels to run the check anyways. But I did not have a look at the azure setup yet, so will see what I can come up with :) |
Oh, what I meant is that we sorta do a check in the same job as running the tests. I was thinking this should be separated out into a job which does "build and check" together, rather than including it in the testing job. |
Ahh, I see. Yeah, fine with me. |
twine check
is not great at telling you why it's failing. It would be easier to figure out what caused the break if we were continuously checking for this.Inspired by finding out that
authors
can't have new lines, via an error that sayslong_description
can't have section headings (which definitely isn't true).The text was updated successfully, but these errors were encountered: