Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build and twine check CI task #1585

Closed
ivirshup opened this issue Jan 14, 2021 · 6 comments · Fixed by #1602
Closed

Add build and twine check CI task #1585

ivirshup opened this issue Jan 14, 2021 · 6 comments · Fixed by #1602

Comments

@ivirshup
Copy link
Member

twine check is not great at telling you why it's failing. It would be easier to figure out what caused the break if we were continuously checking for this.

Inspired by finding out that authors can't have new lines, via an error that says long_description can't have section headings (which definitely isn't true).

@Zethson
Copy link
Member

Zethson commented Jan 14, 2021

Currently being added to sfaira:
https://github.com/theislab/sfaira/pull/72/files#diff-de563ce0a02335898f4a4e1bca2fc074614122bfce30b980d7065142806e4defR38

Feel free to just copy the code.

@Zethson Zethson self-assigned this Jan 19, 2021
@Zethson
Copy link
Member

Zethson commented Jan 19, 2021

@ivirshup I've assigned myself and will do it this week.

@ivirshup
Copy link
Member Author

That'd be great, thanks!

I was thinking it could replace this step in the test builds:

https://github.com/theislab/scanpy/blob/5fc12f4a918e21f0c57937b787d52040db046f01/.azure-pipelines.yml#L78-L81

And was thinking of using azure for it instead of actions, just to consolidate CI stuff a bit. I was thinking a build and check could just be a separate job? Open to suggestions on this however.

@Zethson
Copy link
Member

Zethson commented Jan 20, 2021

Yeah, guess eventually we should settle on one CI service. Effectively we should get rid of Travis, since they have serious problems.

I was thinking a build and check could just be a separate job?

Well you have to build the wheels to run the check anyways. But I did not have a look at the azure setup yet, so will see what I can come up with :)

@ivirshup
Copy link
Member Author

Well you have to build the wheels to run the check anyways

Oh, what I meant is that we sorta do a check in the same job as running the tests. I was thinking this should be separated out into a job which does "build and check" together, rather than including it in the testing job.

@Zethson
Copy link
Member

Zethson commented Jan 20, 2021

Ahh, I see. Yeah, fine with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants