Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage PR deploys ourselves #68

Open
ivirshup opened this issue Oct 12, 2022 · 0 comments
Open

Manage PR deploys ourselves #68

ivirshup opened this issue Oct 12, 2022 · 0 comments

Comments

@ivirshup
Copy link
Member

ivirshup commented Oct 12, 2022

@grst suggests:

I think it could be solved by combining two workflows where the first runs on: pull_request and uploads an artifact and the second runs on: workflow_run

I think I like this more:

  • More explicit about how build happens, easier for us to customize
  • Can share the exact build and deploy script
  • Safer(?)

But I'd probably just go with the netlify thing for now since it seems to be working, I should really finish up a poster, and I want previews working for the ecosystem listing PR

Originally posted by @ivirshup in #66 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant