Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate stress_multiplier options completely #8370

Open
fruch opened this issue Aug 15, 2024 · 1 comment · May be fixed by #9218
Open

deprecate stress_multiplier options completely #8370

fruch opened this issue Aug 15, 2024 · 1 comment · May be fixed by #9218
Assignees
@fruch
Labels
Performance

Comments

@fruch
Copy link
Contributor

fruch commented Aug 15, 2024

we found out this options is causing more harm than good

  1. it's replicate the exact name commands, which for write or mixed, generate override we don't always intend
  2. it was proven (in several) that in c-s increasing load with more thread works better
  3. this option doesn't work correctly with docker loaders

given all of those, I would suggest removing this option from SCT
and as follow up adjusting cases that was using with other options we have (number of threads)

there is usage of it, only in 3 config files,
2 in cases plan to deprecate,
and on in alternator perf case, that isn't used for quite some time
@fruch fruch assigned juliayakovlev and unassigned fruch Aug 15, 2024
@roydahan
Copy link
Contributor

Once we deprecate the tests, It's fine to deprecate it.

@fruch fruch assigned fruch and unassigned roydahan and juliayakovlev Sep 26, 2024
fruch added a commit to fruch/scylla-cluster-tests that referenced this issue Nov 14, 2024
@fruch
fix(stress_threads): clearing stress_multiplier option, and `stress…
3632ab7 
…_num` arguments

those option are not really optimal was to double load, since they are doing
the same exact commands, we stopped using them in performence tests
and we should stop using it across the borad, hence it is removed.

Fixes: scylladb#8370
@fruch fruch linked a pull request Nov 14, 2024 that will close this issue
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fruch fruch

Labels
Performance
Projects
None yet
Milestone
No milestone
3 participants
@fruch @roydahan @juliayakovlev