Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support for other plugin sample rates #59

Closed
sdatkinson opened this issue Feb 5, 2023 · 2 comments · Fixed by #397
Closed

[FEATURE] Support for other plugin sample rates #59

sdatkinson opened this issue Feb 5, 2023 · 2 comments · Fixed by #397
Assignees
Labels
enhancement New feature or request priority:high important

Comments

@sdatkinson
Copy link
Owner

Is your feature request related to a problem? Please describe.
The plugin is made to run at 48kHz. If you don't, it won't sound right.

Describe the solution you'd like
Keep the plugin sounding the same at different sample rates. A resampling block would do the trick.

Describe alternatives you've considered
Getting along with 48k.

Additional context
This doesn't seem to be a big deal to most users so far.

@sdatkinson sdatkinson added the enhancement New feature or request label Feb 5, 2023
@sdatkinson sdatkinson changed the title [FEATURE] Support for other sample rates [FEATURE] Support for other plugin sample rates Feb 19, 2023
@sdatkinson
Copy link
Owner Author

This Issue is for running the plugin at different sample rates. Models that were trained on data at different sample rates is out of scope.

@sdatkinson
Copy link
Owner Author

Now that sdatkinson/neural-amp-modeler#284 is in, we're clear to get this implemented 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:high important
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant