Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING] Rename v3_0_0.wav to input.wav #443

Closed
sdatkinson opened this issue Jul 21, 2024 · 3 comments · Fixed by #459
Closed

[BREAKING] Rename v3_0_0.wav to input.wav #443

sdatkinson opened this issue Jul 21, 2024 · 3 comments · Fixed by #459
Labels
breaking This will be a breaking change

Comments

@sdatkinson
Copy link
Owner

Following #442 , rename the input signal to something more simple :)
@sdatkinson sdatkinson added the breaking This will be a breaking change label Jul 21, 2024
@sdatkinson sdatkinson mentioned this issue Jul 29, 2024
Open
4 tasks
@sdatkinson
Copy link
Owner Author

Support both names for a version, then remove support for the old name.

@sdatkinson
Copy link
Owner Author

sdatkinson commented Sep 10, 2024 •
edited
Loading

Link to input.wav (same as v3_0_0.wav)

@sdatkinson
Copy link
Owner Author

output.wav to go with it for the tutorials

This was referenced Sep 11, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking This will be a breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename v3_0_0.wav to input.wav sdatkinson/neural-amp-modeler
1 participant
@sdatkinson