Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting error New React version #2

Closed
ishaan-puniani opened this issue May 27, 2018 · 6 comments · Fixed by #3
Closed

Getting error New React version #2

ishaan-puniani opened this issue May 27, 2018 · 6 comments · Fixed by #3

Comments

@ishaan-puniani
Copy link

Hello,
I am trying this component.
On application compiling I am getting error
Module not found: Can't resolve 'react/lib/update' in 'C:\GitHub\node_modules\react-addons-update'

If you can please update it to work with latest verion of react as there are some breaking chnages in new update
facebook/react#9207

My application

"dependencies": {
"axios": "^0.18.0",
"react-redux": "^5.0.7",
"react": "^16.2.0",
"react-redux-datatable": "^1.2.4",
"react-router-dom": "^4.2.2",
"react-scripts": "1.1.1",
"redux": "^3.7.2",
"redux-form": "^7.3.0",
"url-search-params-polyfill": "^4.0.0",
"connected-react-router": "^4.3.0"
}

@sean-ww
Copy link
Owner

sean-ww commented Jun 6, 2018

The current version doesn’t support react 16. I’m looking at migrating the project to use react-bootstrap-table2 along with updating to react 16. However, this will take time as react-bootstrap-table2 is still yet to fully implement all of the features from the first version. In the meantime I could recommend using react-bootstrap-table2 directly if it has the features you need.

@thclark
Copy link

thclark commented Jun 21, 2018

@sean-ww nice work, this'll be a really useful component. But, any chance of putting a line about this into the install/quickstart guide? It'll save people going through a couple of hours installing / configuring the package only to find they can't use it! Cheers :)

@sean-ww
Copy link
Owner

sean-ww commented Jun 21, 2018

@thclark thanks, it is listed in the peer dependencies which should then tell you straight away when you try to install it with the wrong version of react, unless I’m mistaken.

@sean-ww sean-ww closed this as completed Jun 21, 2018
@sean-ww sean-ww reopened this Jun 21, 2018
@thclark
Copy link

thclark commented Jun 21, 2018

Thanks Sean, unfortunately, it turns out that npm doesn't do that, because the ^15.x.y notation only indicates "compatible with this" rather than "not compatible with others". If it helps, dependencies can be given with < x.y.z notation which would cause an error on install in that case :)

@sean-ww
Copy link
Owner

sean-ww commented Jun 22, 2018

Ah that's good to know

@thclark
Copy link

thclark commented Jun 22, 2018

Yeah, I'd really thought it meant something else until finding this! Lessons learned I guess :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants