Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quinn dependencies are pulled in even if not using the http3 feature #2318

Closed
jqnatividad opened this issue Jun 17, 2024 · 3 comments
Closed

quinn dependencies are pulled in even if not using the http3 feature #2318

jqnatividad opened this issue Jun 17, 2024 · 3 comments
Labels
B-upstream Blocked: upstream. Depends on a dependency to make a change first.

Comments

@jqnatividad
Copy link
Contributor

as the title states...
@seanmonstar
Copy link
Owner

Are you sure? I just checked the Cargo.toml, and it's all correctly set to optional. And when I create a new project and depend on just reqwest, I don't see quinn downloaded.

@jqnatividad
Copy link
Contributor Author

jqnatividad commented Jun 17, 2024 •
edited
Loading

I use several reqwest features in my project that may be pulling it in...

https://github.com/jqnatividad/qsv/blob/6ffd0c717467e676c54dc3a906983f4c89006f50/Cargo.toml#L182-L193

If you check this dependabot PR for reqwest 0.12.5 - you can see the cargo.lock file has quinn

jqnatividad/qsv#1889

@seanmonstar
Copy link
Owner

You're correct. If you enable rustls-tls, since that has a quinn?/ring dependency, it gets added. It doesn't get compiled, though.

It seems like it is this bug in cargo: rust-lang/cargo#10801

@seanmonstar seanmonstar closed this as not planned Won't fix, can't repro, duplicate, stale Jun 17, 2024
@seanmonstar seanmonstar added the B-upstream Blocked: upstream. Depends on a dependency to make a change first. label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-upstream Blocked: upstream. Depends on a dependency to make a change first.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seanmonstar @jqnatividad