Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: correct redis registry built-in properties #4162

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

Pinocchio2018
Copy link
Contributor

@Pinocchio2018 Pinocchio2018 commented Nov 30, 2021

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

correct built-in properties for redis registry center

for example,
change seata.registry.redis.test.on.borrow to seata.registry.redis.test-on-borrow

Ⅱ. Does this pull request fix one issue?

fixes #3704

Ⅲ. Why don't you add test cases (unit test/integration test)?

I don't know how to do it

Ⅳ. Describe how to verify it

I change application.yml in server module , like this

seata:
  ......
  registry:
    # support: nacos 、 eureka 、 redis 、 zk  、 consul 、 etcd3 、 sofa
    type: redis
    redis:
      server-addr: localhost:6379
      db: 0
      password:
      cluster: default
      timeout: 0

then start ServerApplication. It works

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.5.0 milestone Nov 30, 2021
@funky-eyes funky-eyes added module/discovery discovery module type: bug Category issues or prs related to bug. labels Nov 30, 2021
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit f901e08 into apache:develop Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/discovery discovery module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

使用 redis 注册的问题
3 participants