-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: rename variable "filedSequence" to "rowSequence" for better understanding #4836
optimize: rename variable "filedSequence" to "rowSequence" for better understanding #4836
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 请在changes文件夹 中英两版的develop.md进行作者和pr登记,我认为这个pr是一个优化可读性的pr,所以应该是一个optimize
Codecov Report
@@ Coverage Diff @@
## develop #4836 +/- ##
==========================================
Coverage 49.22% 49.22%
+ Complexity 4092 4091 -1
==========================================
Files 736 736
Lines 25721 25721
Branches 3176 3176
==========================================
Hits 12660 12660
+ Misses 11713 11712 -1
- Partials 1348 1349 +1
|
已经补充 changes 文件夹中 pr 登记 |
…nding
Ⅰ. Describe what this PR did
rename "filedSequence" to "rowSequence" for better understanding
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews