Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: rename variable "filedSequence" to "rowSequence" for better understanding #4836

Merged
merged 3 commits into from
Aug 8, 2022

Conversation

duanqiaoyanyu
Copy link
Contributor

@duanqiaoyanyu duanqiaoyanyu commented Aug 3, 2022

…nding

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

rename "filedSequence" to "rowSequence" for better understanding

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@duanqiaoyanyu duanqiaoyanyu changed the title refactor: rename "filedSequence" to "rowSequence" for better understa… refactor: rename "filedSequence" to "rowSequence" for better understanding Aug 3, 2022
@duanqiaoyanyu duanqiaoyanyu changed the title refactor: rename "filedSequence" to "rowSequence" for better understanding refactor: rename variable "filedSequence" to "rowSequence" for better understanding Aug 3, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.6.0 milestone Aug 6, 2022
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 请在changes文件夹 中英两版的develop.md进行作者和pr登记,我认为这个pr是一个优化可读性的pr,所以应该是一个optimize

@funky-eyes funky-eyes changed the title refactor: rename variable "filedSequence" to "rowSequence" for better understanding optimize: rename variable "filedSequence" to "rowSequence" for better understanding Aug 6, 2022
@funky-eyes funky-eyes added first-time contributor first-time contributor module/rm-datasource rm-datasource module type: optimize labels Aug 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2022

Codecov Report

Merging #4836 (7f72a4f) into develop (5b15922) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4836   +/-   ##
==========================================
  Coverage      49.22%   49.22%           
+ Complexity      4092     4091    -1     
==========================================
  Files            736      736           
  Lines          25721    25721           
  Branches        3176     3176           
==========================================
  Hits           12660    12660           
+ Misses         11713    11712    -1     
- Partials        1348     1349    +1     
Impacted Files Coverage Δ
.../rm/datasource/exec/BaseTransactionalExecutor.java 55.92% <100.00%> (ø)
...erver/storage/file/session/FileSessionManager.java 47.77% <0.00%> (-0.64%) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.76% <0.00%> (+0.73%) ⬆️

@duanqiaoyanyu
Copy link
Contributor Author

LGTM 请在changes文件夹 中英两版的develop.md进行作者和pr登记,我认为这个pr是一个优化可读性的pr,所以应该是一个optimize

已经补充 changes 文件夹中 pr 登记

@funky-eyes funky-eyes merged commit 61349de into apache:develop Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor module/rm-datasource rm-datasource module type: optimize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants