Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For calibrate_model, by default use random initial guess? #81

Closed
TorkelE opened this issue Sep 24, 2023 · 2 comments · Fixed by #84
Closed

For calibrate_model, by default use random initial guess? #81

TorkelE opened this issue Sep 24, 2023 · 2 comments · Fixed by #84

Comments

@TorkelE
Copy link
Contributor

TorkelE commented Sep 24, 2023

Would it make sense to, for calibrate_model, if an initial parameter guess (p0) is not provided, simply randomly select one from within the bounds (and priors) of the parameters? It feels like this will typically be a random value, in which case providing functionality for it might be good.

@sebapersson
Copy link
Owner

Hmm, I am against this, as I would like calibrate_model to mimic most available optimizers that all require a start-guess to be generated.

But it would be nice to to have functionality for start-guesses, so maybe a good solution would be to export the generate_startguesses function, and make it return a vector in case the user only wants 1 start-guess?

@TorkelE
Copy link
Contributor Author

TorkelE commented Sep 25, 2023

Consistency is probably best here, and a generate_startguesses should serve the same purpose as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants