Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter: Don't print to stdout the warnings due to an invalid spec. #126

Merged
merged 1 commit into from
Jan 26, 2019

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Jan 26, 2019

This makes programs that rely on the output of other programs not work properly
in these cases. stderr is more appropriate for such things.

Indeed, if you export RUST_LOG="xxx=xxx" before building this crate for the
first time, the build fails :)

See rust-lang/rust-bindgen#1502.

This makes programs that rely on the output of other programs not work properly
in these cases. stderr is more appropriate for such things.

Indeed, if you `export RUST_LOG="xxx=xxx"` before building this crate for the
first time, the build fails :)

See rust-lang/rust-bindgen#1502.
Copy link
Collaborator

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me

@KodrAus KodrAus merged commit 811db32 into rust-cli:master Jan 26, 2019
@emilio emilio deleted the no-stdout branch January 26, 2019 03:41
@emilio
Copy link
Contributor Author

emilio commented Jan 26, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants