Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML report generator allows invalid values for low upper bound and high lower bound #736

Closed
rask opened this issue Mar 10, 2020 · 0 comments
Assignees

Comments

@rask
Copy link

rask commented Mar 10, 2020

Q A
php-code-coverage version Latest
PHP version 7.4
Installation Method Composer
Usage Method vendor/bin/phpunit
PHPUnit version (if used) 9.*

When I define

<logging>
        <log type="coverage-html" 
             target="./tests/reports/coverage" 
             lowUpperBound="90"
             highLowerBound="50" />
</logging>

in my phpunit.xml, the coverage reporter (or PHPUnit) does not complain that the bounds are conflicting (high starts at 50, but low ends at 90). It allows rendering the HTML report, but the result is a bit off, as in it just disregards the middle bounds (yellow), and only renders red and green charts with some logic.

I think this should be an error or warning of some sort, if the user gives conflicting bounds values?

@sebastianbergmann sebastianbergmann self-assigned this Mar 11, 2020
@sebastianbergmann sebastianbergmann changed the title HTML report low/high bounds can conflict without warning HTML report generator allows invalid values for low upper bound and high lower bound Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants