FIX: Downcast time points passed to brier_score #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `times` is a float array and survival times are ints, a downcast of float to int can result in loss of information. Keep the original dtype instead. Closes #317
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #349 +/- ##
=======================================
Coverage 97.88% 97.88%
=======================================
Files 37 37
Lines 3308 3308
Branches 451 451
=======================================
Hits 3238 3238
Misses 33 33
Partials 37 37
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
What does this implement/fix? Explain your changes
If
timesis a float array and survival times are ints, a downcast of float to int can result in loss of information. Keep the original dtype instead.