Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in 00-introduction.ipynb with nbsphinx 0.9.2 #367

Merged
merged 4 commits into from
Jun 2, 2023

Conversation

cpoerschke
Copy link
Contributor

@cpoerschke cpoerschke commented Jun 2, 2023

Checklist

  • closes #xxxx
  • pytest passes
  • tests are included
  • code is well formatted
  • documentation renders correctly

What does this implement/fix? Explain your changes

Recent CI runs fail with Warning, treated as error: /home/runner/work/scikit-survival/scikit-survival/doc/user_guide/00-introduction.ipynb:35:undefined label: /user_guide/00-introduction.ipynb#the-veterans%27-administration-lung-cancer-trial and experimentally the link on https://scikit-survival.readthedocs.io/en/stable/user_guide/00-introduction.html is broken. The https://scikit-survival.readthedocs.io/en/latest/user_guide/00-introduction.html links work though.

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d5fcbc9) 97.92% compared to head (dc07f00) 97.92%.

❗ Current head dc07f00 differs from pull request most recent head ad73a13. Consider uploading reports for the commit ad73a13 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #367   +/-   ##
=======================================
  Coverage   97.92%   97.92%           
=======================================
  Files          37       37           
  Lines        3323     3323           
  Branches      502      502           
=======================================
  Hits         3254     3254           
  Misses         33       33           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cpoerschke cpoerschke changed the title tweak link in 00-introduction.ipynb address CI feedback: fix two broken(?) links in 00-introduction.ipynb Jun 2, 2023
@cpoerschke cpoerschke marked this pull request as ready for review June 2, 2023 11:47
@sebp
Copy link
Owner

sebp commented Jun 2, 2023

It's strange that CI fails now. For me, the links to on the stable and latest docs work both fine. It might be that a newer version of sphinx (or its dependencies) is used on CI, compared to readthedocs.

@sebp
Copy link
Owner

sebp commented Jun 2, 2023

I can confirm that this is caused by nbsphinx 0.9.2.

@sebp
Copy link
Owner

sebp commented Jun 2, 2023

@cpoerschke Could you please change

"nbsphinx",

to

"nbsphinx>=0.9.2",

@sebp sebp changed the title address CI feedback: fix two broken(?) links in 00-introduction.ipynb Fix broken links in 00-introduction.ipynb with nbsphinx 0.9.2 Jun 2, 2023
@sebp sebp merged commit d2834af into sebp:master Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants