Improve performance of SurvivalTree #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Construct total risk set without sorting - Compute risk set for left node on the fly - Rename event_times_ to unique_times_ everywhere Fixes #343
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #371 +/- ##
=======================================
Coverage 97.92% 97.92%
=======================================
Files 37 37
Lines 3324 3326 +2
Branches 502 502
=======================================
+ Hits 3255 3257 +2
Misses 33 33
Partials 36 36
☔ View full report in Codecov by Sentry. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
What does this implement/fix? Explain your changes
event_times_attribute tounique_times_everywhere