Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Cython functions as noexcept #418

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Mark Cython functions as noexcept #418

merged 1 commit into from
Nov 19, 2023

Conversation

sebp
Copy link
Owner

@sebp sebp commented Nov 19, 2023

Checklist

  • pytest passes
  • tests are included
  • code is well formatted
  • documentation renders correctly

What does this implement/fix? Explain your changes
Marks Cython functions as noexcept to release the GIL.

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (92119ee) 98.04% compared to head (11fd856) 98.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #418   +/-   ##
=======================================
  Coverage   98.04%   98.04%           
=======================================
  Files          37       37           
  Lines        3426     3426           
  Branches      517      517           
=======================================
  Hits         3359     3359           
  Misses         32       32           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebp sebp merged commit 668a02b into master Nov 19, 2023
31 checks passed
@sebp sebp deleted the cython-noexcept branch November 19, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant