Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Enable windows builds #326

Open
lukpueh opened this issue Feb 11, 2021 · 1 comment
Open

GitHub Actions: Enable windows builds #326

lukpueh opened this issue Feb 11, 2021 · 1 comment
Assignees
Labels
tests Issues related to testing

Comments

@lukpueh
Copy link
Member

lukpueh commented Feb 11, 2021

Description of issue or feature request:
Configure recently added GitHub Actions workflow (see #324) to run tests on windows too.

This is likely to require some troubleshooting, see:

Current behavior:
tests run on linux and mac

Expected behavior:
tests run on linux, mac and windows

@jku
Copy link
Collaborator

jku commented Feb 19, 2021

I think the TestStorage failure is a test bug and maybe an issue with path handling :

  1. test_exceptions() does create_folder('/none/existent/path'): not sure who should be taking care of OS specific things here
  2. Even if the path is nomalized for windows, it would end up on the current drive. I think the whole current drive is writable in github actions... so test should not fail there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Issues related to testing
Projects
None yet
Development

No branches or pull requests

2 participants