Skip to content

Commit

Permalink
[rb] remove assertions in virtual authenticator tests
Browse files Browse the repository at this point in the history
Chrome 117 started returning the same values for rpId and userHandle in both resident and non-resident credentials. This behavior is not evaluated in wpt tests, so removing the checks in Selenium.
  • Loading branch information
titusfortner committed Sep 23, 2023
1 parent ab1fe36 commit 4621945
Showing 1 changed file with 1 addition and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -194,17 +194,10 @@ def credential(id)
expect(credentials.length).to eq(2)

res_cred_output = credentials.find { |cred| Credential.encode(cred.id).match res_cred_resp['id'] }
non_res_cred_output = credentials.tap { |cred| cred.delete(res_cred_output) }.first
non_res_cred_output = credentials.find { |cred| cred != res_cred_output }

expect(res_cred_output.resident_credential?).to be true
expect(res_cred_output.rp_id).to eq 'localhost'
expect(res_cred_output.sign_count).to eq 1
expect(res_cred_output.user_handle).to eq [1]

expect(non_res_cred_output.resident_credential?).to be false
expect(non_res_cred_output.rp_id).to be_nil
expect(non_res_cred_output.sign_count).to eq 1
expect(non_res_cred_output.user_handle).to be_nil
end
end

Expand Down

1 comment on commit 4621945

@Pandapotanmarpaung
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like

Please sign in to comment.