[rb] allow service to be started before the driver

SeleniumHQ · Sep 24, 2023 · f843e8b · f843e8b
1 parent e5ce6fd
commit f843e8b
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 5 deletions.
diff --git a/rb/lib/selenium/webdriver/common/service.rb b/rb/lib/selenium/webdriver/common/service.rb
@@ -87,6 +87,10 @@ def initialize(path: nil, port: nil, log: nil, args: nil)
       end
 
       def launch
+        @executable_path ||= begin
+          default_options = WebDriver.const_get("#{self.class.name.split('::')[2]}::Options").new
+          DriverFinder.path(default_options, self.class)
+        end
         ServiceManager.new(self).tap(&:start)
       end
 

diff --git a/rb/spec/integration/selenium/webdriver/chrome/service_spec.rb b/rb/spec/integration/selenium/webdriver/chrome/service_spec.rb
@@ -26,10 +26,15 @@ module Chrome
         let(:service) { described_class.new }
         let(:service_manager) { service.launch }
 
-        before { service.executable_path = DriverFinder.path(Options.new, described_class) }
         after { service_manager.stop }
 
         it 'auto uses chromedriver' do
+          service.executable_path = DriverFinder.path(Options.new, described_class)
+
+          expect(service_manager.uri).to be_a(URI)
+        end
+
+        it 'can be started outside driver' do
           expect(service_manager.uri).to be_a(URI)
         end
       end

diff --git a/rb/spec/integration/selenium/webdriver/edge/service_spec.rb b/rb/spec/integration/selenium/webdriver/edge/service_spec.rb
@@ -26,10 +26,15 @@ module Edge
         let(:service) { described_class.new }
         let(:service_manager) { service.launch }
 
-        before { service.executable_path = DriverFinder.path(Options.new, described_class) }
         after { service_manager.stop }
 
         it 'auto uses edgedriver' do
+          service.executable_path = DriverFinder.path(Options.new, described_class)
+
+          expect(service_manager.uri).to be_a(URI)
+        end
+
+        it 'can be started outside driver' do
           expect(service_manager.uri).to be_a(URI)
         end
       end

diff --git a/rb/spec/integration/selenium/webdriver/firefox/service_spec.rb b/rb/spec/integration/selenium/webdriver/firefox/service_spec.rb
@@ -26,14 +26,18 @@ module Firefox
         let(:service) { described_class.new }
         let(:service_manager) { service.launch }
 
-        before { service.executable_path = DriverFinder.path(Options.new, described_class) }
         after { service_manager.stop }
 
         it 'auto uses geckodriver' do
-          service_manager = service.launch
+          service.executable_path = DriverFinder.path(Options.new, described_class)
+
+          expect(service_manager.uri).to be_a(URI)
+        end
+
+        it 'can be started outside driver' do
           expect(service_manager.uri).to be_a(URI)
         end
       end
-    end # Chrome
+    end # Firefox
   end # WebDriver
 end # Selenium