Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore .npmrc to its original state #145

Closed
pvdlg opened this issue Mar 6, 2019 · 2 comments · Fixed by #198
Closed

Restore .npmrc to its original state #145

pvdlg opened this issue Mar 6, 2019 · 2 comments · Fixed by #198

Comments

@pvdlg
Copy link
Member

pvdlg commented Mar 6, 2019

The plugin create a local .npmrc file for authentication.
After each step (verifyConditions, prepare, publish, addChannel) we should restore the local .npmrc to its original state:

  • If there was no .npmrc file we should delete the one we have created
  • If there was a .npmrc file we should restore it

See semantic-release/semantic-release#1109

@pvdlg
Copy link
Member Author

pvdlg commented Oct 3, 2019

It seems there is some interest from npm to support authentication via environment variables. That would avoid to have to modify the .npmrc.
The feature has been implemented but it doesn't works: npm/cli#8 and https://npm.community/t/cannot-set-npm-config-keys-containing-underscores-registry-auth-tokens-for-example-via-npm-config-environment-variables/233

@semantic-release-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants