Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ruby_http_client 3.5.0 in version range #411

Closed
mkilling opened this issue Mar 5, 2020 · 1 comment · Fixed by #412
Closed

Allow ruby_http_client 3.5.0 in version range #411

mkilling opened this issue Mar 5, 2020 · 1 comment · Fixed by #412
Labels
difficulty: easy fix is easy in difficulty status: work in progress Twilio or the community is in the process of implementing type: bug bug in the library

Comments

@mkilling
Copy link

mkilling commented Mar 5, 2020

Issue Summary

sendgrid-ruby 6.1.0 caused this issue sendgrid/ruby-http-client#117 to appear in our production environment. ruby-http-client has recently fixed the issue in version 3.5.0, but the current sendgrid-ruby release 6.1.1 (released at about the same time) still only allows for ruby-http-client ~> 3.4.0.

Steps to Reproduce

  1. Install sendgrid-ruby 6.1.1
  2. Post an array to the Sendgrid API (see code snippet
  3. Exception: undefined method bytesize' for #Array:0x00007f11061d84e0 (see Gem Release 6.1.0 Passing Post Body Results in Error ruby-http-client#117)

Code Snippet

SendGrid::API.new(api_key: API_KEY).client.contactdb.recipients.post(request_body: [])

Exception/Log

undefined method bytesize' for #Array:0x00007f11061d84e0

Technical details:

  • sendgrid-ruby version: 6.1.1
  • ruby version: 2.5.3
@mkilling mkilling changed the title Allow ruby_http_client dependency 3.5.0 in version range Allow ruby_http_client 3.5.0 in version range Mar 5, 2020
@childish-sambino childish-sambino added difficulty: easy fix is easy in difficulty status: work in progress Twilio or the community is in the process of implementing type: bug bug in the library labels Mar 5, 2020
@childish-sambino
Copy link
Contributor

Yup, looks like an issue with the version constraint. We should be allowing minor version bumps. Working on PR to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: work in progress Twilio or the community is in the process of implementing type: bug bug in the library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants