Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the plan to add support for projects using packages.config? #15

Closed
notofug opened this issue Dec 21, 2023 · 4 comments
Closed

Is the plan to add support for projects using packages.config? #15

notofug opened this issue Dec 21, 2023 · 4 comments

Comments

@notofug
Copy link
Collaborator

notofug commented Dec 21, 2023

Asking in an issue since no discussion activated here :-)

I see ref to packages.config-based projects and would love support for that.

I have mixed environment setup with C# (reference-style) and C++ projects that must use packages.config-style. (e.g : nlohmann/json#1132 (comment))

image

Beeing able to handle 'everything' would be great 👍

@sensslen
Copy link
Owner

sensslen commented Dec 21, 2023

Projects using packages.config should be supported - that said: I have not done a lot of testing around that. There is a test that runs on CI testing the ability to handle packages.config projects.... See https://github.com/sensslen/nuget-license/tree/main/tests/targets/PackagesConfigProject

I'd love to accept contributions in that regard.

@notofug
Copy link
Collaborator Author

notofug commented Dec 21, 2023

I saw that test-project and that made me optimistic, but then I saw this among the testcases :

$"Invalid project structure detected. Currently only PackageReference projects are supported (Project: {path})",

Anyway , great that it is on the table, I may have a go at something!

@sensslen
Copy link
Owner

Oh, right - there was something. If you find a way to actually support legacy projects, I'll happily accept. However I seem to recall that packagesconfig projects are not supported by the nuget library provided by microsoft.

@sensslen
Copy link
Owner

sensslen commented Jan 2, 2024

This has been resolved with #17. Thank you very much for your contribution!

@sensslen sensslen closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants