Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yum package versioning is busted #623

Open
sspans opened this issue Nov 7, 2018 · 3 comments
Open

Yum package versioning is busted #623

sspans opened this issue Nov 7, 2018 · 3 comments

Comments

@sspans
Copy link

sspans commented Nov 7, 2018

Yum package versioning is busted because epoch is not used

Expected Behavior

The expected sensu version is installed.

Current Behavior

When upgrading to chef 14, the symptom is continual reinstallations of the sensu package. Which also seems to indicate busted version comparisons for yum_package.

Possible Solution

According to chef/chef#7552 this should be fixed by adding the epoch to the desired version.

Optionally I would suggest installing the package directly, without configuring a yum repository. The current setup breaks when somebody does a 'yum upgrade' because this will pull in newer versions of the sensu packages.

Context

Your Environment

  • Version of this cookbook used: latest
  • Version of Sensu used: 1.2.0
  • Version of Chef used: 14.5
  • Operating System and version (e.g. CentOS 7, Ubuntu 14.04): CentOS 7.5
  • Link to your project:
@sspans
Copy link
Author

sspans commented Nov 7, 2018

I'll update the issue with a pull-request to fix this tomorrow.

@lamont-granquist
Copy link

make sure to test on chef-13 that it takes an epoch, its possible its not backcompatible and you'd need to switch based on chef-client version, i didn't check to see what the old behavior is.

@majormoses
Copy link
Contributor

I would think that we need to replicate this: https://github.com/sensu/sensu-chef/blob/v5.4.0/recipes/_linux.rb#L56-L64 to https://github.com/sensu/sensu-chef/blob/v5.4.0/recipes/_linux.rb#L83-L87 but I don't really have a lot of time to test various platforms and suspect this would break a bunch of old setups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants