Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What should we do with the 'jamtis_mock_keys' struct? #61

Open
rbrunner7 opened this issue Sep 15, 2023 · 1 comment
Open

What should we do with the 'jamtis_mock_keys' struct? #61

rbrunner7 opened this issue Sep 15, 2023 · 1 comment

Comments

@rbrunner7
Copy link
Member

In the Seraphis library there is the struct jamtis_mock_keys. It holds a number of keys, some secret, some public, including the most important of them all, "the" key k_m. The header file containing it is here.

The "mock" in the filename and its location in a folder that also contains "mocks" usually means that it's part of the testing framework and thus not part of the "production code".

I could not find another similar struct in the Seraphis library that is part of the normal code.

I see this as a possible job that somebody could pick up: Check whether we need something like that as part of normal code, e.g. as base for reading and writing keys in the wallet, and if yes, find out how that struct should look, and what relationship there would be with jamtis_mock_keys.

Is a simple copy of that struct, under a different name, in a different location, the proper way to go? Or does a wallet need a new struct for itself that maybe the Seraphis library proper hasn't even a need for?

@DangerousFreedom1984
Copy link

I think @ghostway0 work on the key_container should address that. I vote for creating a file in seraphis_wallet/ folder with the name 'jamtis_keys'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants