Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use kuberesolver with go modules since addition of go.mod #11

Closed
bmhatfield opened this issue Feb 4, 2020 · 2 comments
Closed

Comments

@bmhatfield
Copy link

I am not 100% sure what to do about this, but the error message is:

module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v2

And the relevant Go issue is: golang/go#35732

I believe the root of the problem is that the import path does not end in /v2, but the tag is v2.3.0. This was previously fine because there was no go.mod on this repo, allowing for the use of +incompatible, but now that the repo has a go.mod, that does not work anymore.

I was able to temporarily work around this by using a computed version without referencing the tags, but it's sad to lose that version metadata.

@sercand
Copy link
Owner

sercand commented Feb 5, 2020

@bmhatfield Thanks for the report. I will be looking this today.

@sercand
Copy link
Owner

sercand commented Feb 5, 2020

I removed go.mod and released v2.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants