Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirtualScrollPicker is never actually exposed #120

Closed
lyle45 opened this issue Apr 25, 2021 · 4 comments
Closed

VirtualScrollPicker is never actually exposed #120

lyle45 opened this issue Apr 25, 2021 · 4 comments
Labels
question Further information is requested

Comments

@lyle45
Copy link

lyle45 commented Apr 25, 2021

VirtualScrollPicker is never actually exposed only declared, so you can't import and use it.

@serebrov
Copy link
Owner

@lyle45 I am actually trying to get rid of VirtualScrollPicker in favor of Picker. It did not give a lot of performance improvement, but created quite a lot of problems (see #80).

So I first switched to Picker as a default component and removed VirtualScrollPicker from exports in the last update.
It is not complex to add it back to exports, but the problem is that I did not port all the recent accessibility and keyboard control changes from #106 to the VirtualScrollPicker component, so it would be lacking some features.

Do you find VirtualScrollPicker to be useful (better than Picker)?

In general, if you need it for some specific use case, you can also use its source as an example, all other components are exported and can be used as building blocks to componse your own picker.

@lyle45
Copy link
Author

lyle45 commented May 2, 2021

@serebrov Understand your problem

Do you have an example on how to integrate the default picker with a virtual scroller (currently performance is not good :\ )
For e.g. how to integrate the emoji list with Quasars virtual scroller?

https://quasar.dev/vue-components/virtual-scroll

@serebrov
Copy link
Owner

serebrov commented May 2, 2021

@lyle45 I think you can do import VirtualScrollPicker from "emoji-mart-vue-fast/src/components/VirtualScrollPicker" to get the VirtualScrollPicker.

As for the example - the component code itself can be used as an example of composing the picker from other components.

The Picker component is similar, but with keyboard support.

Also, could you share more observations on the performance? How do you measure the performance and in which scenario you see the virtual scroller advantage?

@serebrov serebrov added the question Further information is requested label May 2, 2021
@skjnldsv
Copy link

I guess you can close since it got removed #241

@serebrov serebrov closed this as completed Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants