Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype selectable emoji. #268

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

serebrov
Copy link
Owner

@serebrov serebrov commented May 7, 2023

Prototype selectable emoji for [#253].

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2023

Codecov Report

Merging #268 (6b09e0c) into master (6b62180) will increase coverage by 0.36%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
+ Coverage   89.42%   89.79%   +0.36%     
==========================================
  Files          15       16       +1     
  Lines         577      578       +1     
  Branches      143      143              
==========================================
+ Hits          516      519       +3     
+ Misses         55       54       -1     
+ Partials        6        5       -1     
Impacted Files Coverage Δ
src/components/Picker.vue 100.00% <ø> (ø)
src/components/preview.vue 100.00% <ø> (ø)
src/utils/shared-props.js 100.00% <ø> (ø)
src/components/selectedEmoji.vue 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Show the external `selectedEmoji` in the picker, rely on external
code to unset it when `unselect` event is sent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants