Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Want support for v8 encryption modes #246

Closed
FelixMcFelix opened this issue Aug 16, 2024 · 0 comments · Fixed by #264
Closed

Want support for v8 encryption modes #246

FelixMcFelix opened this issue Aug 16, 2024 · 0 comments · Fixed by #264
Labels
driver Relates to the driver or one of its sub-tasks. enhancement New feature or request

Comments

@FelixMcFelix
Copy link
Member

We have a (sudden) deadline of November 18th to implement Discord's new encryption modes for voice:

  • aead_aes256_gcm_rtpsize
  • aead_xchacha20_poly1305_rtpsize

In tandem, we must deprecate (but not rename) the old encryption modes in CryptoMode (Normal, Suffix, Lite) -- this change should be non-breaking if executed correctly. aead_aes256_gcm_rtpsize should be the new default choice.

There is one non-trivial part of this, which is that the new encryption modes finally treat RTP correctly, and are compliant with the SRTP spec. From what I recall, this places extension headers into the plaintext segment and moves the auth tag formally into the RTP body segment instead of interposed between the RTP header and its extensions. Supporting both modes will be finicky but otherwise doable.

Relevant RFCs:

@FelixMcFelix FelixMcFelix added enhancement New feature or request driver Relates to the driver or one of its sub-tasks. labels Aug 16, 2024
@tignear tignear mentioned this issue Nov 9, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
driver Relates to the driver or one of its sub-tasks. enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant