Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wont build on python 2 #1

Closed
reconbot opened this issue Jan 2, 2022 · 3 comments · Fixed by #2
Closed

Wont build on python 2 #1

reconbot opened this issue Jan 2, 2022 · 3 comments · Fixed by #2

Comments

@reconbot
Copy link
Member

reconbot commented Jan 2, 2022

Half of the prebuildify-cross images use python 2 prebuild/docker-images#15 so we can't build on them. I'm not sure why however.

@thegecko
Copy link
Contributor

thegecko commented Jan 4, 2022

Linked PR fixes this issue, but if you want to use different cross-build images (e.g. with python3 installed), you'll need to roll your own containers.

See here for example:

https://github.com/node-usb/docker-images

@reconbot
Copy link
Member Author

reconbot commented Jan 6, 2022

I like the node-usb docker images, any reason we couldn't use those?

@thegecko
Copy link
Contributor

thegecko commented Jan 6, 2022

I like the node-usb docker images, any reason we couldn't use those?

They won't contain python3 :)

They were needed to add the libudev-dev compilation dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants