Skip to content

Commit

Permalink
fix: prebuild on mojave (#1759)
Browse files Browse the repository at this point in the history
OSX Mojave has issues building for node 6. Prebuild tries to build for everything we support and that includes node 6. Node 6 was built with `libstdc++` and osx has (over the past few years, along with nodejs core) moved to `libc++` as the standard library. It no longer supports it with xcode 10 and that's what ships with Mojave.

References
- Workaround until we drop node 6 nodejs/node#23685 (comment)
- More background nodejs/node#24648

I reformatted trying to work around this issue. Glad it's solved.
  • Loading branch information
reconbot authored Dec 31, 2018
1 parent 5c3c42a commit d4f5128
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/bindings/binding.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
'src/darwin_list.cpp'
],
'xcode_settings': {
'MACOSX_DEPLOYMENT_TARGET': '10.9',
'OTHER_LDFLAGS': [
'-framework CoreFoundation -framework IOKit'
]
Expand Down

0 comments on commit d4f5128

Please sign in to comment.