Running on Windows without flow control

[kealist]

• SerialPort Version: 5.0.0

• NodeJS Version: v6.11.1

• Operating System and Hardware Platform: Windows 10

• Have you checked the right version of the api docs?: I assume so (readme.md)

• Are you having trouble installing and you checked the Installation Special Cases docs? No

• Are you using Electron and have you checked the Electron Docs?: No

Summary of Problem

Trying to control robot whose interface requires no flow control. It's not working.

I am not familiar enough with Node modules to test these changes, so I am writing out some questions/concerns. Current issues in terms of how the dcb is treated in src/serialport_win.cpp

EIO_Open

Unsupported openOptions:

• rtscts (hardcoded)
• xon (hardcoded)
• xoff (hardcoded)
• xany (hardcoded)

Additionally, hupcl is missing from documentation, but it does allow disabling DTR (Yay!)

  if (data->hupcl) {
    dcb.fDtrControl = DTR_CONTROL_ENABLE;
  } else {
    dcb.fDtrControl = DTR_CONTROL_DISABLE;  // disable DTR to avoid reset
  }

Lack of control of RTS:

  dcb.fInX = FALSE;
  dcb.fOutX = FALSE;
  dcb.fOutxDsrFlow = FALSE;
  dcb.fOutxCtsFlow = FALSE;
  dcb.fRtsControl = RTS_CONTROL_ENABLE;

The last hardcoded line is problematic because there is no way to disable RTS. It would be better set as:

  if (data->rtscts) {
    dcb.fRtsControl = RTS_CONTROL_ENABLE;
  } else {
    dcb.fRtsControl = RTS_CONTROL_DISABLE;
 }

to match the Unix version.

Steps and Code to Reproduce the Issue

[reconbot]

This is a great catch, thank you!