Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): tone down codecov comments #1289

Merged
merged 1 commit into from
Aug 7, 2017
Merged

feat(test): tone down codecov comments #1289

merged 1 commit into from
Aug 7, 2017

Conversation

reconbot
Copy link
Member

@reconbot reconbot commented Aug 7, 2017

No description provided.

@codecov-io
Copy link

codecov-io commented Aug 7, 2017

Codecov Report

Merging #1289 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1289      +/-   ##
==========================================
- Coverage   78.97%   78.95%   -0.03%     
==========================================
  Files          20       20              
  Lines         899      898       -1     
  Branches      164      164              
==========================================
- Hits          710      709       -1     
  Misses        189      189
Impacted Files Coverage Δ
lib/bindings/win32.js 69.64% <0%> (-0.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b554d7...f0ba2c8. Read the comment docs.

@reconbot reconbot merged commit 749ffac into master Aug 7, 2017
@reconbot reconbot deleted the codecov branch August 7, 2017 03:35
reconbot added a commit that referenced this pull request Aug 7, 2017
### Bug Fixes

* **linux:** The productID should be a number not a description string ([#1279](#1279)) ([bf46f68](bf46f68))
* **tests:** fixup for [#1279](#1279) ([#1285](#1285)) ([56074f6](56074f6))
* **windows:** Add option to disable RTS ([#1277](#1277)) ([5b8d163](5b8d163))
* **windows:** Parse more types of pnpIds ([#1288](#1288)) ([0b554d7](0b554d7)), closes [#1220](#1220)


### Chores

* **binaries:** Lets switch to prebuild! ([#1282](#1282)) ([8c36e99](8c36e99))


### Features

* **test:** tone down codecov comments ([#1289](#1289)) ([749ffac](749ffac))


### BREAKING CHANGES

* **binaries:** I'm considering the switch to `prebuild` a breaking change because it's substantially changes our install processes. It's also possible the install flags to ensure downloading or building from source has changed slightly. That's not our api per say, but it's enough.
* **windows:** We previously hard coded to have RTS on for windows at all times it now default to off.
@lock lock bot locked and limited conversation to collaborators Feb 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants